optimize: use hget replace hmget because only one field #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4761 +/- ##
=============================================
- Coverage 49.20% 49.20% -0.01%
+ Complexity 4091 4090 -1
=============================================
Files 736 736
Lines 25723 25723
Branches 3177 3177
=============================================
- Hits 12657 12656 -1
Misses 11716 11716
- Partials 1350 1351 +1
|
…ptimize-redislock
funky-eyes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
In io.seata.server.storage.redis.lock.RedisLocker and 362 line, there only one field, so we should use hget not hmget
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
run io.seata.server.lock.redis.RedisLockManagerTest#unLock()
Ⅴ. Special notes for reviews