Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connector-V2][JDBC] Support database: greenplum #2429

Merged
merged 9 commits into from
Aug 24, 2022
Merged

[Connector-V2][JDBC] Support database: greenplum #2429

merged 9 commits into from
Aug 24, 2022

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Aug 16, 2022 •
edited
Loading

Support connect greenplum drivers:

  • postgresql driver: org.postgresql.Driver
  • greenplum driver: com.pivotal.jdbc.GreenplumDriver

Purpose of this pull request

Support jdbc connect greenplum #1946

Check list

wanghailin added 4 commits August 16, 2022 18:15
[Connector-V2][JDBC] Support database: Greenplum
a7ee6a4 
Support connect greenplum drivers:
* postgresql driver: org.postgresql.Driver
* greenplum driver: com.pivotal.jdbc.GreenplumDriver
fix codestyle
60e3ed4
test
78b8310
update
656b5c0
@EricJoy2048
Copy link
Member

Please add the document of this connector.

@hailin0
Copy link
Member Author

hailin0 commented Aug 18, 2022

Please add the document of this connector.

updated

ic4y
ic4y reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add tests for Stream mode and tests for XA transaction(two-phase commit)

docs/en/connector-v2/sink/Greenplum.md Show resolved Hide resolved
...k-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcGreenplumIT.java Outdated Show resolved Hide resolved
wanghailin added 2 commits August 22, 2022 15:30
@hailin0
Copy link
Member Author

hailin0 commented Aug 22, 2022

Can we also add tests for Stream mode and tests for XA transaction(two-phase commit)

@ic4y updated

@ic4y
Copy link
Contributor

ic4y commented Aug 22, 2022

@hailin0 JDBC Sink supports Stream mode. Can it be covered in tests？

@hailin0
Copy link
Member Author

hailin0 commented Aug 23, 2022 •
edited
Loading

@hailin0 JDBC Sink supports Stream mode. Can it be covered in tests？

Stream mode only dedicated to source?

@ic4y
Copy link
Contributor

ic4y commented Aug 23, 2022

@hailin0 JDBC Sink supports Stream mode. Can it be covered in tests？

Stream mode only dedicated to source?

No. Stream mode only dedicated to Sink

@hailin0
Copy link
Member Author

hailin0 commented Aug 23, 2022

@hailin0 JDBC Sink supports Stream mode. Can it be covered in tests？

Stream mode only dedicated to source?

No. Stream mode only dedicated to Sink

Not support exactly-once semantics (XA transaction is not yet supported in Greenplum database).

@hailin0
Copy link
Member Author

hailin0 commented Aug 23, 2022

@CalvinKirs please review

@ic4y
Copy link
Contributor

ic4y commented Aug 23, 2022

@hailin0 Thanks
+1

@CalvinKirs CalvinKirs merged commit 3561d38 into apache:dev Aug 24, 2022
@hailin0 hailin0 mentioned this pull request Aug 25, 2022
Merged
3 tasks
@Hisoka-X Hisoka-X mentioned this pull request Aug 30, 2022
Closed
@hailin0 hailin0 mentioned this pull request Sep 1, 2022
Closed
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
@hailin0 @TyrantLucifer
[Connector-V2][JDBC] Support database: greenplum (apache#2429)
71bcb49 
* [Connector-V2][JDBC] Support database: Greenplum

Support connect greenplum drivers:
* postgresql driver: org.postgresql.Driver
* greenplum driver: com.pivotal.jdbc.GreenplumDriver

Co-authored-by: wanghailin <hailin@fiture.com>
@EricJoy2048 EricJoy2048 mentioned this pull request Oct 8, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ic4y ic4y ic4y left review comments

@ashulin ashulin ashulin left review comments

@EricJoy2048 EricJoy2048 EricJoy2048 left review comments

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hailin0 @EricJoy2048 @ic4y @CalvinKirs @ashulin