-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type #3067
[Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type #3067
Conversation
Your pull request changed the core module without proposal. Please refer to Coding Guide change your pr request. I think Int128,Int256 Type can using @Hisoka-X PLAL. |
551920b
to
8df4d26
Compare
I found that it can be achieved with String data type, which has passed the E2E test. @Hisoka-X PLAL. |
…_int256' into clickhouse_source_support_int128_int256
We should support it both source side and sink side, so we should test read int128 from clickhouse source and write it into clickhouse table. |
Yes, I have already tested. source_table = """ sink_table = """ env { source { transform { sink { |
I have a question, why not use decimal to implement int128 and int256? |
Because decimal only supports up to 38 digits in spark, Int128 and Int256 have exceeded 38 digits, and Spark reported an exception. |
I use String type in spark, Decimal type in other places, it's ok. So I thought, can I only use the String type, I tested it later and found that it is possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of this pull request
Clickhouse Support Int128,Int256 Type #3057
Check list
New License Guide