Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed for #3234 insert without columns #3314

Closed
wants to merge 1 commit into from
Closed

fixed for #3234 insert without columns #3314

wants to merge 1 commit into from

Conversation

xiyelife
Copy link
Contributor

Fixes #3234

resumbit my PR and associate to #3295. (recreate the branch to resolve the conflict)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 688

  • 33 of 35 (94.29%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 67.88%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/generator/impl/EncryptForInsertColumnsTokenGenerator.java 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/parameter/builder/impl/StandardParameterBuilder.java 1 94.12%
Totals Coverage Status
Change from base Build 489: 0.02%
Covered Lines: 11317
Relevant Lines: 16672

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When insert by mybatis, the parameters were still found to be out of ordered.
3 participants