Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD #11244

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Oct 12, 2020

SUMMARY

This feature flag has been enabled by default for months now, let's remove it.

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @ktmud @villebro @john-bodley

] = lambda database, user: [
UPLOADED_CSV_HIVE_NAMESPACE
] if UPLOADED_CSV_HIVE_NAMESPACE else []
ALLOWED_USER_CSV_SCHEMA_FUNC: Callable[["Database", "models.User"], List[str]] = (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess black likes this formatting better 🤷

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #11244 into master will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11244      +/-   ##
==========================================
- Coverage   65.61%   65.45%   -0.17%     
==========================================
  Files         832      832              
  Lines       39394    39394              
  Branches     3592     3592              
==========================================
- Hits        25848    25784      -64     
- Misses      13437    13501      +64     
  Partials      109      109              
Flag Coverage Δ
#cypress 55.89% <ø> (-0.18%) ⬇️
#javascript 62.40% <ø> (ø)
#python 60.61% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 74.11% <ø> (ø)
superset/config.py 90.07% <100.00%> (ø)
...rontend/src/visualizations/FilterBox/FilterBox.jsx 56.17% <0.00%> (-9.88%) ⬇️
superset/db_engine_specs/presto.py 73.65% <0.00%> (-8.43%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 97.36% <0.00%> (-2.64%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 83.67% <0.00%> (-2.05%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 90.47% <0.00%> (-1.59%) ⬇️
...t-frontend/src/dashboard/actions/dashboardState.js 50.32% <0.00%> (-1.31%) ⬇️
superset/models/core.py 88.12% <0.00%> (-0.28%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae87b0c...d1dd53d. Read the comment docs.

@ktmud
Copy link
Member

ktmud commented Oct 13, 2020

Merge to unblock #11234

@ktmud ktmud merged commit 6cf698c into apache:master Oct 13, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants