Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary to specify order_columns for DatasourceModelView #3331

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Unnecessary to specify order_columns for DatasourceModelView #3331

merged 1 commit into from
Aug 18, 2017

Conversation

roganw
Copy link
Contributor

@roganw roganw commented Aug 18, 2017

changed_on_ and offset are not included in the list_columns of DruidDatasourceModelView.
And changed_on_ is not included in the list_columns of TableModelView.

The default value of order_columns is get fromlist_columns.

@coveralls
Copy link

coveralls commented Aug 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 69.388% when pulling da21eff on RoganW:remove_order_columns into 9f3aeb2 on apache:master.

@mistercrunch mistercrunch merged commit 813ed60 into apache:master Aug 18, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roganw @coveralls @mistercrunch