-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superset issue #4512: multiple metrics, group by, opacity, legends for histogram #4525
Conversation
Also, if you guys do decide to merge this, maybe we should change the thumbnail for the histogram viz? |
This is very cool |
I love it! Any chance to get this PR merged before the next release? |
@mistercrunch would you mind taking a look at it? I'd be happy to keep working on it if need be. |
@ArielStv, I finally took the time to pull the branch and play with this. This is solid, merging! |
@mistercrunch was this functionality deprecated at some point? Or does it require a custom configuration of sorts? |
Trying to address issue #4512 and going further than PR #4513.
This PR gives the ability to have multiple histograms in the same chart. Features added:
There could be a case for using nvd3 for histograms. I looked into it quickly and it didn't seem obvious to me how to make it work in a simple way. I'm also not a big fan of the
multiBarChart
feature (there is a PR opened for this though - #3777 - not sure where it's at).Further possible improvements: better way of assigning bin numbers and bar widths across groups (right now, all groups are assigned the same number of bins, and width is computed accordingly), align bars on the x-axis, assign one distinct opacity value per group.
Of note: the group-by option here is different from the group-by option for other viz: there is no aggregation function applied. Instead, the 'raw' data for each group is used to plot the histograms.