[get_df] Adding support for multi-statement SQL #5060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working part of an Airbnb project to which leverages a custom SQLAlchemy dialect executes multiple-statements as it needs to create a series of temporary views before issuing the final select.
Many engines don't support multiple statements, i.e., one cannot provide a single string containing multiple-statements separated by the
;
character and thus the only viable option seems to be to to mutateget_df
to execute each statement separately using the same connection. Only the results from the last statement are fetched.@mistercrunch I'm not sure how you feel about this change as it does not directly benefit any existing Superset use cases. I'm definitely open to other suggestion, though I sense this is fairly benign.
to: @GabeLoins @michellethomas @mistercrunch