[Explore][Adhoc Filters] fixing LIKE constant name #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5110 +/- ##
======================================
Coverage 77.5% 77.5%
======================================
Files 44 44
Lines 8720 8720
======================================
Hits 6758 6758
Misses 1962 1962Continue to review full report at Codecov.
|
michellethomas
approved these changes
May 30, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Jun 6, 2018
(cherry picked from commit f3778c3)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name for the like function is incorrect, and is causing LIKE filters to be dropped by flask.
test plan:
created a like filter and verified it worked:
run specs
reviewers:
@john-bodley @michellethomas @graceguo-supercat @mistercrunch