-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce class attr BaseViz.enforce_numerical_metrics #5176
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5176 +/- ##
==========================================
+ Coverage 77.46% 77.47% +<.01%
==========================================
Files 44 44
Lines 8729 8732 +3
==========================================
+ Hits 6762 6765 +3
Misses 1967 1967
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm This seems like a good solution to me. Ideally we'd be getting the correct types in pandas and wouldn't need to coerce to num at all, but when I looked around I didn't find a great solution to this problem.
When were you seeing the incorrect object
types (what are the steps to reproduce)? Just for future reference it would be nice to better understand the problem.
@mistercrunch this lgtm, merge? |
Related unmerged PR here: |
(cherry picked from commit a109543)
@michellethomas