Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add week granularity for Clickhouse #5455

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

qeorqe
Copy link
Contributor

@qeorqe qeorqe commented Jul 21, 2018

This PR adds week granularity for Clickhouse queries.
Native Clickhouse function toMonday() rounds down a date/datetime to the nearest Monday and returns the date.

@codecov-io
Copy link

codecov-io commented Jul 21, 2018

Codecov Report

Merging #5455 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5455   +/-   ##
=======================================
  Coverage   59.11%   59.11%           
=======================================
  Files         372      372           
  Lines       23756    23756           
  Branches     2758     2758           
=======================================
  Hits        14044    14044           
  Misses       9697     9697           
  Partials       15       15
Impacted Files Coverage Δ
superset/db_engine_specs.py 53.6% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c545fdf...f845b88. Read the comment docs.

@mistercrunch mistercrunch merged commit 0d5443e into apache:master Jul 21, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants