Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace metadata refresh stacktrace with danger flash #5536

Merged
merged 3 commits into from
Aug 2, 2018
Merged

Replace metadata refresh stacktrace with danger flash #5536

merged 3 commits into from
Aug 2, 2018

Conversation

villebro
Copy link
Member

@villebro villebro commented Aug 1, 2018 •
edited
Loading

Before:
screen shot 2018-08-01 at 18 42 58

After:
screen shot 2018-08-01 at 23 17 44

@codecov-io
Copy link

codecov-io commented Aug 1, 2018 •
edited
Loading

Codecov Report

Merging #5536 into master will decrease coverage by 0.02%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5536      +/-   ##
==========================================
- Coverage   63.29%   63.26%   -0.03%     
==========================================
  Files         349      349              
  Lines       22188    22198      +10     
  Branches     2467     2467              
==========================================
  Hits        14043    14043              
- Misses       8131     8141      +10     
  Partials       14       14
Impacted Files Coverage Δ
superset/connectors/druid/views.py 68.24% <0%> (ø) ⬆️
superset/connectors/sqla/views.py 64.34% <0%> (-6.13%) ⬇️
superset/views/base.py 67.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9831730...a6114a6. Read the comment docs.

@villebro villebro changed the title Replace metadata refresh stacktrace with danger flash [WIP] Replace metadata refresh stacktrace with danger flash Aug 1, 2018
@villebro
Copy link
Member Author

villebro commented Aug 1, 2018

Will group successful and unsuccessful refreshes together for max 2 flashes.

@villebro villebro changed the title [WIP] Replace metadata refresh stacktrace with danger flash Replace metadata refresh stacktrace with danger flash Aug 1, 2018
@villebro
Copy link
Member Author

villebro commented Aug 1, 2018

This should be ready for review @mistercrunch

@mistercrunch mistercrunch merged commit 906dcd8 into apache:master Aug 2, 2018
@villebro villebro deleted the flash_metafail branch August 2, 2018 12:39
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@villebro @mistercrunch
Replace metadata refresh stacktrace with danger flash (apache#5536)
5de8737 
* Replace stacktrace with danger flash

* Group successful and failed refreshes and fix typos

* Fix linting
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villebro @codecov-io @mistercrunch