Add categories and time slider to arc deck.gl viz #5638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5638 +/- ##
==========================================
+ Coverage 63.51% 63.54% +0.02%
==========================================
Files 360 361 +1
Lines 22890 22889 -1
Branches 2549 2547 -2
==========================================
+ Hits 14539 14545 +6
+ Misses 8336 8329 -7
Partials 15 15
Continue to review full report at Codecov.
|
|
LGTM |
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 11, 2018
* Fix legend position * Add categories and play slider to arc viz * New functionality to arc viz (cherry picked from commit 6959b70)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Fix legend position * Add categories and play slider to arc viz * New functionality to arc viz
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for categorical colors in the arc deck.gl viz. I refactored the code that handles the categorization out of the scatter viz, and created a new component
CategoricalDeckGLContainer. The component handles the interactive legend (toggling categories), as well as the play slider and the Javascript mutations.