Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression around low row limit for CSV exports #5866

Merged
merged 3 commits into from
Sep 19, 2018
Merged

Fix regression around low row limit for CSV exports #5866

merged 3 commits into from
Sep 19, 2018

Conversation

mistercrunch
Copy link
Member

betodealmeida
betodealmeida reviewed Sep 12, 2018
View reviewed changes
superset/views/core.py Outdated
return json_success(
json.dumps(
payload_json, default=utils.json_iso_dttm_ser, ignore_nan=True))

return json_success(utils.zlib_decompress_to_string(blob))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsy

hughhhh
hughhhh reviewed Sep 12, 2018
View reviewed changes
tests/core_tests.py Outdated
@@ -634,6 +633,7 @@ def test_import_csv(self):
os.remove(filename)

def test_dataframe_timezone(self):
import psycopg2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import tz from psycopg2

@codecov-io
Copy link

Codecov Report

Merging #5866 into master will increase coverage by 6.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5866      +/-   ##
==========================================
+ Coverage   48.16%   54.26%   +6.09%     
==========================================
  Files         393      328      -65     
  Lines       23596    14013    -9583     
  Branches     2630     2607      -23     
==========================================
- Hits        11366     7604    -3762     
+ Misses      12230     6396    -5834     
- Partials        0       13      +13
Impacted Files Coverage Δ
superset/assets/src/SqlLab/getInitialState.js 0% <0%> (-57.15%) ⬇️
superset/assets/src/chart/ChartBody.jsx 64% <0%> (-7.43%) ⬇️
...rc/explore/components/controls/AnnotationLayer.jsx 22.92% <0%> (ø) ⬆️
...perset/assets/src/visualizations/MapBox/MapBox.jsx 0% <0%> (ø) ⬆️
superset/assets/src/visualizations/rose.js 0% <0%> (ø) ⬆️
superset/assets/src/visualizations/sunburst.js 0% <0%> (ø) ⬆️
.../assets/src/visualizations/BigNumber/BigNumber.jsx 0% <0%> (ø) ⬆️
superset/assets/src/visualizations/pivot_table.js 0% <0%> (ø) ⬆️
...t/assets/src/dashboard/reducers/getInitialState.js 0% <0%> (ø) ⬆️
...explore/components/controls/SelectAsyncControl.jsx 56% <0%> (ø) ⬆️
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549328f...ca046d3. Read the comment docs.

@mistercrunch
Copy link
Member Author

Addressed comments, merging.

@mistercrunch mistercrunch merged commit b9e3159 into apache:master Sep 19, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
Fix regression around low row limit for CSV exports (apache#5866)
ede4141 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
Fix regression around low row limit for CSV exports (apache#5866)
d358ff2 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
bb6859a 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
a668236 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
cf07512 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
be30b91 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
Fix regression around low row limit for CSV exports (apache#5866)
06a014c 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
Fix regression around low row limit for CSV exports (apache#5866)
bb0deff 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
Fix regression around low row limit for CSV exports (apache#5866)
adba901 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
Fix regression around low row limit for CSV exports (apache#5866)
cbb4e7c 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
@mistercrunch
Fix regression around low row limit for CSV exports (apache#5866)
d28a665 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
3510e75 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
5d25feb 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
3506978 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
251736d 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
Fix regression around low row limit for CSV exports (apache#5866)
ec3ac92 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
Fix regression around low row limit for CSV exports (apache#5866)
390e673 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
Fix regression around low row limit for CSV exports (apache#5866)
f12b9d4 
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests

(cherry picked from commit b9e3159)
(cherry picked from commit d358ff2)
@mistercrunch mistercrunch mentioned this pull request Feb 26, 2019
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida left review comments

@hughhhh hughhhh hughhhh left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistercrunch @codecov-io @betodealmeida @hughhhh