-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TO Go caches/stats endpoint #2278
Conversation
Refer to this link for build results (access rights to CI server needed): |
3092455
to
1d33436
Compare
Refer to this link for build results (access rights to CI server needed): |
1d33436
to
d2d3309
Compare
Refer to this link for build results (access rights to CI server needed): |
d2d3309
to
1a292ce
Compare
Refer to this link for build results (access rights to CI server needed): |
1a292ce
to
fe64f64
Compare
Refer to this link for build results (access rights to CI server needed): |
b840ce8
to
864a1d1
Compare
Refer to this link for build results (access rights to CI server needed): |
067edcc
to
22df4a4
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Previously, the endpoint returned an error if the first monitor it tried failed. This changes it to retry all online monitors.
22df4a4
to
544906c
Compare
Refer to this link for build results (access rights to CI server needed): |
@ocket8888 is going to review this PR |
@@ -103,6 +104,8 @@ func Routes(d ServerData) ([]Route, []RawRoute, http.Handler, error) { | |||
{1.1, http.MethodPost, `asns/?$`, api.CreateHandler(asn.GetTypeSingleton()), auth.PrivLevelOperations, Authenticated, nil}, | |||
{1.1, http.MethodDelete, `asns/{id}$`, api.DeleteHandler(asn.GetTypeSingleton()), auth.PrivLevelOperations, Authenticated, nil}, | |||
|
|||
{1.1, http.MethodGet, `caches/stats/?(\.json)?$`, cachesstats.Get, auth.PrivLevelReadOnly, Authenticated, nil}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is unique to this endpoint, but this will allow me to GET
/api/1.x/caches/stats/.json
. I checked and it seems that the Perl allows this, so maybe for that reason alone we don't want to change it, but it's weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works exactly like the Perl endpoint from what I can see.
This endpoint queries the Traffic Monitor; the "API Test" framework doesn't currently support endpoints that hit the Monitor.