-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-19 - ORT now errors if a https cert is not found #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangogh
reviewed
Nov 2, 2016
} | ||
} | ||
#if no cert is found, log error and exit | ||
( $log_level >> $FATAL ) && print "FATAL SSL certificate for $remap not found!\n"; | ||
exit 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation issue here?
rimashah25
pushed a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Dec 4, 2023
…pache#21) * nitial changes * Maple auth and query working * Maple auth working, placeholder for queries for now * Cleanup and final changes * Refactor and code review * Remove extra blank line, go fmt * Adding tests * formatting * WIP * maple query for kbps mid working * database name/ table name changes * summary stats * do not divide by 8, already being done in maple query * series query fixed * fixed percentiles, totalKB * readme changes * adding tests * revert unneeded changes * revert unneeded changes * formatting * add blank line, go fmt tests * Adding kbps metric * Making changes for the tps queries * Adding more tests * Changing metric names * code review fixes * Fix build * fix test * fixing go vendor pkg dependencies * Code review fixes * README changes * change import sequence Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Weasel build fixes (apache#22) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Add remaining metrics: avg_ttms and origin_offload for Maple/TO integration (apache#23) * Initial changes for avg_ttms * add origin_offload metric and tests * Moving gonum pkg to the root vendor dir, for compatibility with go modules * changing the route from 3.1 to 3.0 * Changing the route back to 3.1 Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Changing the ds_stats route from 3.1 to 3.0 TO should point to Maple, instead of influxdb to get delivery_stats (apache#21) * nitial changes * Maple auth and query working * Maple auth working, placeholder for queries for now * Cleanup and final changes * Refactor and code review * Remove extra blank line, go fmt * Adding tests * formatting * WIP * maple query for kbps mid working * database name/ table name changes * summary stats * do not divide by 8, already being done in maple query * series query fixed * fixed percentiles, totalKB * readme changes * adding tests * revert unneeded changes * revert unneeded changes * formatting * add blank line, go fmt tests * Adding kbps metric * Making changes for the tps queries * Adding more tests * Changing metric names * code review fixes * Fix build * fix test * fixing go vendor pkg dependencies * Code review fixes * README changes * change import sequence Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Weasel build fixes (apache#22) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Add remaining metrics: avg_ttms and origin_offload for Maple/TO integration (apache#23) * Initial changes for avg_ttms * add origin_offload metric and tests * Moving gonum pkg to the root vendor dir, for compatibility with go modules * changing the route from 3.1 to 3.0 * Changing the route back to 3.1 Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Changing the ds_stats route from 3.1 to 3.0 change route prefix to 3.1 (apache#26) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> (cherry picked from commit 85037a0) Maple TO plugin improvements (apache#27) * updating plugin paths to not be hardcoded * Summary query missing limit Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Restructuring the queries so that Trickster picks them up (apache#29) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Don't log error when request is unhandled (cherry picked from commit 9762cf78958fa7a460301c218d2a73082099016a) Change queries for maple upgrade (apache#30) * Change the query structure, in order to comply with Maple upgrades * code review Adding maple logging for failure cases (apache#33) * Adding maple logging for failure cases * code review changes Adding Maple error response to logs (apache#34) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Disney tps pssc aggregate and cache_efficiency metrics (apache#35) * Initial changes for new tps_all metrics * making sure output is in correct format * add cache_efficiency metric Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Add cache_capacity to deliveryservice-stats plugin (apache#36) * add cache capacity * Make cache_capacity work with series/summary * Code review fixes * Wrong case Disney billing api (apache#37) * Initial changes * formatting * remove unneeded return param * cleanup * remove code duplication * remove unneeded mutex * code review fixes * change comparison logic * address code review Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Adding new metric for disney (apache#38) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Calculate Remaining Capacity for cache_capacity (apache#39) * Calculate available based on current, correct units on available * Add logging to bad conversion Co-authored-by: shamrickus <shamrickus@gmail.com> Determine capacity from parameter instead of TM (apache#42) * Determine capacity from parameter * gb -> gbps Co-authored-by: shamrickus <shamrickus@gmail.com> Disney billing info and contract api (apache#41) * initial changes * adding changes for info and contract APIs * adding documentation and other changes * renaming plugin * rename plugin, remove debug statement * revert unneeded commit * remove TS changes * license * code review comments Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Disney documentation (apache#40) * Adding documentation for Disney metrics * adding documentation for a new metric * Documentation * license and cache capacity docs * Improve cc docs Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Co-authored-by: shamrickus <shamrickus@gmail.com> Add support to get responses by tenant (apache#43) * Add support to get responses by tenant * code review changes Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Pass routeID in context (apache#45) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Pass route ID in the right format (apache#47) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com>
rimashah25
pushed a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a https certificate is not found for a delivery service, ORT now logs a FATAL message and exits. This fixes TC-19.
Also updated the update_riak_for_search script so it does not exit when it gets an error.