Add --skip-ssl option to post install to skip auto generation of SSL …#30
Add --skip-ssl option to post install to skip auto generation of SSL …#30limited wants to merge 3 commits intoapache:masterfrom limited:skipssl
Conversation
| my $skip_ssl = 0; | ||
| GetOptions("skip-ssl" => \$skip_ssl) | ||
| or die ("Error in command line arguments"); | ||
|
|
There was a problem hiding this comment.
indentation issues both here and below.. perltidy?
traffic_ops/install/bin/postinstall
Outdated
| my $parameters; | ||
|
|
||
| my $skip_ssl = 0; | ||
| GetOptions("skip-ssl" => \$skip_ssl) |
There was a problem hiding this comment.
how about adding a --help? No way to tell what the option is without looking thru the source..
|
I'll fix, need a day or so |
|
perltidy went crazy on me here- any suggestions on how to adjust @dangogh ? I copy and pasted the lines as is from the traffic-control-cdn developers page |
|
Not yet, but Peter suggested adding a question to the input in 126 to allow a user to skip it. I would support that approach over this PR. |
|
I think this should be closed -- postinstall now has To skip cert generation, change this answer to |
…pache#21) * nitial changes * Maple auth and query working * Maple auth working, placeholder for queries for now * Cleanup and final changes * Refactor and code review * Remove extra blank line, go fmt * Adding tests * formatting * WIP * maple query for kbps mid working * database name/ table name changes * summary stats * do not divide by 8, already being done in maple query * series query fixed * fixed percentiles, totalKB * readme changes * adding tests * revert unneeded changes * revert unneeded changes * formatting * add blank line, go fmt tests * Adding kbps metric * Making changes for the tps queries * Adding more tests * Changing metric names * code review fixes * Fix build * fix test * fixing go vendor pkg dependencies * Code review fixes * README changes * change import sequence Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Weasel build fixes (apache#22) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Add remaining metrics: avg_ttms and origin_offload for Maple/TO integration (apache#23) * Initial changes for avg_ttms * add origin_offload metric and tests * Moving gonum pkg to the root vendor dir, for compatibility with go modules * changing the route from 3.1 to 3.0 * Changing the route back to 3.1 Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Changing the ds_stats route from 3.1 to 3.0 TO should point to Maple, instead of influxdb to get delivery_stats (apache#21) * nitial changes * Maple auth and query working * Maple auth working, placeholder for queries for now * Cleanup and final changes * Refactor and code review * Remove extra blank line, go fmt * Adding tests * formatting * WIP * maple query for kbps mid working * database name/ table name changes * summary stats * do not divide by 8, already being done in maple query * series query fixed * fixed percentiles, totalKB * readme changes * adding tests * revert unneeded changes * revert unneeded changes * formatting * add blank line, go fmt tests * Adding kbps metric * Making changes for the tps queries * Adding more tests * Changing metric names * code review fixes * Fix build * fix test * fixing go vendor pkg dependencies * Code review fixes * README changes * change import sequence Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Weasel build fixes (apache#22) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Add remaining metrics: avg_ttms and origin_offload for Maple/TO integration (apache#23) * Initial changes for avg_ttms * add origin_offload metric and tests * Moving gonum pkg to the root vendor dir, for compatibility with go modules * changing the route from 3.1 to 3.0 * Changing the route back to 3.1 Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Changing the ds_stats route from 3.1 to 3.0 change route prefix to 3.1 (apache#26) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> (cherry picked from commit 85037a0) Maple TO plugin improvements (apache#27) * updating plugin paths to not be hardcoded * Summary query missing limit Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Restructuring the queries so that Trickster picks them up (apache#29) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Don't log error when request is unhandled (cherry picked from commit 9762cf78958fa7a460301c218d2a73082099016a) Change queries for maple upgrade (apache#30) * Change the query structure, in order to comply with Maple upgrades * code review Adding maple logging for failure cases (apache#33) * Adding maple logging for failure cases * code review changes Adding Maple error response to logs (apache#34) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Disney tps pssc aggregate and cache_efficiency metrics (apache#35) * Initial changes for new tps_all metrics * making sure output is in correct format * add cache_efficiency metric Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Add cache_capacity to deliveryservice-stats plugin (apache#36) * add cache capacity * Make cache_capacity work with series/summary * Code review fixes * Wrong case Disney billing api (apache#37) * Initial changes * formatting * remove unneeded return param * cleanup * remove code duplication * remove unneeded mutex * code review fixes * change comparison logic * address code review Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Adding new metric for disney (apache#38) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Calculate Remaining Capacity for cache_capacity (apache#39) * Calculate available based on current, correct units on available * Add logging to bad conversion Co-authored-by: shamrickus <shamrickus@gmail.com> Determine capacity from parameter instead of TM (apache#42) * Determine capacity from parameter * gb -> gbps Co-authored-by: shamrickus <shamrickus@gmail.com> Disney billing info and contract api (apache#41) * initial changes * adding changes for info and contract APIs * adding documentation and other changes * renaming plugin * rename plugin, remove debug statement * revert unneeded commit * remove TS changes * license * code review comments Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Disney documentation (apache#40) * Adding documentation for Disney metrics * adding documentation for a new metric * Documentation * license and cache capacity docs * Improve cc docs Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Co-authored-by: shamrickus <shamrickus@gmail.com> Add support to get responses by tenant (apache#43) * Add support to get responses by tenant * code review changes Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Pass routeID in context (apache#45) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com> Pass route ID in the right format (apache#47) Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com>
Button location moved out of dropdown
…certificate
This fixes Comcast/traffic_control#1179