[TC-478] Parameter value can be changed to 0 #758
Conversation
| @@ -317,7 +317,7 @@ sub update { | |||
|
|
|||
| my $name = $params->{name} || $find->name; | |||
| my $configFile = $params->{configFile} || $find->config_file; | |||
| my $value = $params->{value} || $find->value; | |||
| my $value = exists($params->{value}) ? $params->{value} : $find->value; | |||
There was a problem hiding this comment.
what does this allow you to do? to set the parameter value to null? is that what you want to do?
it sounds like by the name of the PR you want to set a parameter value to 0...but parameter values are strings so can you set the value to "0" without this change? and is that sufficient?
There was a problem hiding this comment.
I would like to allow to set the value to 0.
Apparently in Perl the string "0" is equivalent to False....
See http://www.perlmonks.org/?node=what%20is%20true%20and%20false%20in%20Perl%3F
I can replace the "exists" with "defined" if you prefer. I believe that logically "exists"is better, but it really does not matter for this case
There was a problem hiding this comment.
ok, makes sense. i forgot how perl treats 0 or "0"
No description provided.