Fix Windows build #3429
Merged
Fix Windows build #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ritsu1228 the one in expr_functor.h is the correct one, however imo it should be in pass.h. Can you move the docstring to pass.h, and delete instead of uncomment? |
* uint -> uint32_t to match the type of ndim * removing Bind() in expr_functor.h since it appears to be a duplicate of the same function in pass.h * moving docstring of Bind() from expr_functor.h to pass.h
|
@MarisaKirisame Thanks for confirming. Moved docstring to |
tqchen
approved these changes
Jun 27, 2019
|
Thanks, @ritsu1228 , this PR is now merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 28, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint->uint32_tto match the type ofndimBind()inexpr_functor.hsince it appears to be a duplicate of the same function inpass.h. It is better to only keep one declaration. However, they do have different doc strings. Therefore, I think it would be great if one of the authors can confirm and suggest how the doc strings should be merged.