Bug fix] Fix in arm_cpu/conv2d_alter_op for NHWC quantized #6027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2020 18:37
Few minor typos to be fixed in topi/arm_cpu/conv2d_alter_op.py for the NHWC quantized route: - Kernel shape was misread (CO, IC, KH, KW) -> (KH, KW, IC, OC) - Pad along the K dimension was misspelled: pad_k -> pad_K - Workload name was wrong: "conv2d_NHWC_int8_without_tranform.arm_cpu" -> "conv2d_NHWC_quantized_without_transform.arm_cpu" This submission fixes those errors and add a further test for conv2d_alter_op.py Change-Id: I0622df05f1d4d15311946f6e75f1840a34815a5b
Change-Id: Ieff80c774e8ab0fa7f48d83d50a79f3a62e8fe13
giuseros
force-pushed
the
fix_conv2d_alter_op
branch
from
402ced1
to
63b5166
Compare
Change-Id: I5541bed54eacc5063bf4a4fda725209cc23f621e
|
Thanks @giuseros |
|
Thank you @icemelon9 ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
) * Bug fix] Fix in arm_cpu/conv2d_alter_op for NHWC quantized Few minor typos to be fixed in topi/arm_cpu/conv2d_alter_op.py for the NHWC quantized route: - Kernel shape was misread (CO, IC, KH, KW) -> (KH, KW, IC, OC) - Pad along the K dimension was misspelled: pad_k -> pad_K - Workload name was wrong: "conv2d_NHWC_int8_without_tranform.arm_cpu" -> "conv2d_NHWC_quantized_without_transform.arm_cpu" This submission fixes those errors and add a further test for conv2d_alter_op.py Change-Id: I0622df05f1d4d15311946f6e75f1840a34815a5b * Move -target to -mtriple Change-Id: Ieff80c774e8ab0fa7f48d83d50a79f3a62e8fe13 * Retrigger tests Change-Id: I5541bed54eacc5063bf4a4fda725209cc23f621e
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
) * Bug fix] Fix in arm_cpu/conv2d_alter_op for NHWC quantized Few minor typos to be fixed in topi/arm_cpu/conv2d_alter_op.py for the NHWC quantized route: - Kernel shape was misread (CO, IC, KH, KW) -> (KH, KW, IC, OC) - Pad along the K dimension was misspelled: pad_k -> pad_K - Workload name was wrong: "conv2d_NHWC_int8_without_tranform.arm_cpu" -> "conv2d_NHWC_quantized_without_transform.arm_cpu" This submission fixes those errors and add a further test for conv2d_alter_op.py Change-Id: I0622df05f1d4d15311946f6e75f1840a34815a5b * Move -target to -mtriple Change-Id: Ieff80c774e8ab0fa7f48d83d50a79f3a62e8fe13 * Retrigger tests Change-Id: I5541bed54eacc5063bf4a4fda725209cc23f621e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few minor typos to be fixed in topi/arm_cpu/conv2d_alter_op.py for the
NHWC quantized route:
-> "conv2d_NHWC_quantized_without_transform.arm_cpu"
This submission fixes those errors and add a further test for conv2d_alter_op.py
Change-Id: I0622df05f1d4d15311946f6e75f1840a34815a5b