[#647][FOLLOWUP] set coordinator id before ApplicationMaster #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
============================================
+ Coverage 60.60% 62.92% +2.31%
- Complexity 1799 1801 +2
============================================
Files 216 202 -14
Lines 12458 10494 -1964
Branches 1052 1052
============================================
- Hits 7550 6603 -947
+ Misses 4500 3545 -955
+ Partials 408 346 -62 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Merged to Master & 0.7 thanks @advancedxy |
jerqi
pushed a commit
that referenced
this pull request
Feb 24, 2023
### What changes were proposed in this pull request? set coordinator id before ApplicationMaster construction, otherwise uuid is used for ` AbstractSelectStorageStrategy` ### Why are the changes needed? Follow up of #647 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
set coordinator id before ApplicationMaster construction, otherwise uuid is used for
AbstractSelectStorageStrategyWhy are the changes needed?
Follow up of #647
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually verified