Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android]support "wx" in animation and wxtext #2783

Merged
merged 3 commits into from Aug 30, 2019
Merged

[Android]support "wx" in animation and wxtext #2783

merged 3 commits into from Aug 30, 2019

Conversation

katherine95s
Copy link
Contributor

No description provided.

YorkShen
YorkShen suggested changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are trying to add wx support for animation and wxtext, maybe you should consider GraphicActionAnimation as well.

android/sdk/src/main/java/com/taobao/weex/utils/WXUtils.java Show resolved Hide resolved
android/sdk/src/main/java/com/taobao/weex/utils/WXViewUtils.java Outdated Show resolved Hide resolved
android/sdk/src/main/java/com/taobao/weex/utils/WXUtils.java Outdated Show resolved Hide resolved
android/sdk/src/main/java/com/taobao/weex/utils/WXViewUtils.java Show resolved Hide resolved
android/sdk/src/main/java/com/taobao/weex/ui/animation/TransformParser.java Outdated Show resolved Hide resolved
@weex-bot
Copy link

weex-bot commented Aug 29, 2019 •
edited

Warnings
⚠️ No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
⚠️ If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue
Messages
📖 danger test finished.

Generated by 🚫 dangerJS against 36aa642

YorkShen
YorkShen suggested changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • {@link ClassName#MethodName(Parameter) is a syntax supported by JavaDoc, you are missing #
  • WXLogUtils.e(String Tag, String Message); . You are using the wrong tag. Actually, WXLogUtils.e(getStackTrace); is enough.

@YorkShen YorkShen added this to the Weex 0.27 milestone Aug 29, 2019
YorkShen
YorkShen approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen
Copy link
Contributor

YorkShen commented Aug 30, 2019 •
edited

Document:

@YorkShen YorkShen merged commit 1f54d46 into apache:master Aug 30, 2019
YorkShen added a commit to YorkShen/incubator-weex that referenced this pull request Sep 5, 2019
@YorkShen
[Android] Change default value to from NAN to 0
ad9a62b 
This is a bug in default value introduced by thttps://github.com/apache/pull/2783 ,which change some default value from 0 to Float.NAN . This commit will revert the behaviour change.
@YorkShen YorkShen mentioned this pull request Sep 5, 2019
Merged
YorkShen added a commit that referenced this pull request Sep 5, 2019
@YorkShen
[Android] Change default value to from NAN to 0 (#2883)
6daad9e 
This is a bug in default value introduced by thttps://github.com//pull/2783 ,which change some default value from 0 to Float.NAN . This commit will revert the behaviour change.
lucky-chen added a commit to lucky-chen/incubator-weex that referenced this pull request Sep 19, 2019
@lucky-chen
Revert "[Android]support "wx" in animation and wxtext (apache#2783)"
30de3f6 
This reverts commit 1f54d46.
@lucky-chen lucky-chen mentioned this pull request Sep 19, 2019
Closed
lucky-chen added a commit to lucky-chen/incubator-weex that referenced this pull request Sep 19, 2019
@lucky-chen
Revert "[Android]support "wx" in animation and wxtext (apache#2783)"
2db2d67 
This reverts commit 1f54d46.
@lucky-chen lucky-chen mentioned this pull request Sep 19, 2019
Merged
YorkShen pushed a commit that referenced this pull request Sep 20, 2019
@lucky-chen @YorkShen
Bugfx/revert 2783 2883 (#2924)
bc32968 
* Revert "[Android] Change default value to from NAN to 0 (#2883)"

This reverts commit 6daad9e.

* Revert "[Android]support "wx" in animation and wxtext (#2783)"

This reverts commit 1f54d46.
YorkShen pushed a commit to YorkShen/incubator-weex that referenced this pull request Sep 26, 2019
@lucky-chen
Revert "[Android]support "wx" in animation and wxtext (apache#2783)"
b9c003a 
This reverts commit 1f54d46.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YorkShen YorkShen YorkShen approved these changes

@Darin726 Darin726 Awaiting requested review from Darin726

@gubaojian gubaojian Awaiting requested review from gubaojian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Weex 0.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katherine95s @weex-bot @YorkShen