Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] Change default value to from Float.NAN to 0 #2883

Merged
merged 1 commit into from Sep 5, 2019
Merged

[Android] Change default value to from Float.NAN to 0 #2883

merged 1 commit into from Sep 5, 2019

Conversation

YorkShen
Copy link
Contributor

@YorkShen YorkShen commented Sep 5, 2019 •
edited

This is a bug in default value introduced by #2783 ,which change some default value from 0 to Float.NAN . This commit will revert the behaviour change.

Brief Description of the PR

Checklist

  • Demo:
  • Documentation:

@YorkShen
[Android] Change default value to from NAN to 0
ad9a62b 
This is a bug in default value introduced by thttps://github.com/apache/pull/2783 ,which change some default value from 0 to Float.NAN . This commit will revert the behaviour change.
@YorkShen YorkShen added this to the Weex 0.27 milestone Sep 5, 2019
@weex-bot
Copy link

weex-bot commented Sep 5, 2019

Warnings
⚠️ No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
⚠️ If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue
⚠️ If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
Messages
📖 danger test finished.

Generated by 🚫 dangerJS against ad9a62b

@YorkShen YorkShen changed the title [Android] Change default value to from NAN to 0 [Android] Change default value to from Float.NAN to 0 Sep 5, 2019
lucky-chen
lucky-chen approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@lucky-chen lucky-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@YorkShen YorkShen merged commit 6daad9e into apache:master Sep 5, 2019
lucky-chen added a commit to lucky-chen/incubator-weex that referenced this pull request Sep 19, 2019
@lucky-chen
Revert "[Android] Change default value to from NAN to 0 (apache#2883)"
8e370b7 
This reverts commit 6daad9e.
@lucky-chen lucky-chen mentioned this pull request Sep 19, 2019
Closed
lucky-chen added a commit to lucky-chen/incubator-weex that referenced this pull request Sep 19, 2019
@lucky-chen
Revert "[Android] Change default value to from NAN to 0 (apache#2883)"
fc227ce 
This reverts commit 6daad9e.
@lucky-chen lucky-chen mentioned this pull request Sep 19, 2019
Merged
YorkShen pushed a commit that referenced this pull request Sep 20, 2019
@lucky-chen @YorkShen
Bugfx/revert 2783 2883 (#2924)
bc32968 
* Revert "[Android] Change default value to from NAN to 0 (#2883)"

This reverts commit 6daad9e.

* Revert "[Android]support "wx" in animation and wxtext (#2783)"

This reverts commit 1f54d46.
YorkShen pushed a commit to YorkShen/incubator-weex that referenced this pull request Sep 26, 2019
@lucky-chen
Revert "[Android] Change default value to from NAN to 0 (apache#2883)"
fe41a75 
This reverts commit 6daad9e.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucky-chen lucky-chen lucky-chen approved these changes

@Darin726 Darin726 Awaiting requested review from Darin726

@gubaojian gubaojian Awaiting requested review from gubaojian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Weex 0.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorkShen @weex-bot @lucky-chen