Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

fix clipPath not works on android N 7.0 #790

Closed
wants to merge 1 commit into from
Closed

fix clipPath not works on android N 7.0 #790

wants to merge 1 commit into from

Conversation

wispy316
Copy link
Contributor

@YorkShen
here is my polyfill. just judge the scaleX、scaleY and so on to fix。

the one with is broken at release-0.16。 see first yellow box. click it will do the animation.
1broken

fixed with the polyfill. clip child view works on the first yellow box.
1works

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Oct 13, 2017

Messages
📖 android test finished.

Generated by 🚫 dangerJS

@wispy316
Copy link
Contributor Author

wispy316 commented Oct 13, 2017

@cxfeng1-zz
Copy link
Contributor

The APK link can't be opened.

@gurisxie
Copy link
Contributor

gurisxie commented Oct 18, 2017

@wispy316 thanks a lot for your pull request.

There are somethings wrong for all weex developers and users.

  1. please not use alibaba local links that other people can't open,such as 'mtl.alibaba-inc.com','rax.alibaba-inc.com'.
  2. By the way, if PR title is of the form [WEEX-xxxx], xxxx is the relevant JIRA number, it will be referenced to the JIRA issue automaticly.

have a better way to join weex.~

@wispy316
Copy link
Contributor Author

update url, @gurisxie @cxfeng1 @cxfeng1

Copy link
Contributor

@gurisxie gurisxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok.

@gurisxie
Copy link
Contributor

has merge rebase ,but bot seems broken.

@asfgit asfgit closed this in 1175064 Nov 21, 2017
atomtong added a commit to atomtong/incubator-weex that referenced this pull request Nov 29, 2017
* master:
  close apache#790,close apache#796,close apache#801,close apache#803
  close apache#884,close apache#886,close apache#889
  -[test] close apache#887
  resolve apache#887
  [WEEX-132][iOS] support text writing direction from right to left
  [WEEX-133][iOS] support word-wrap on iOS when drawing text
  [WEEX-129][android] Appear Event Be Fired Multi Times And Event not watch be fired
  [WEEX-124][android]fix android bug
  * [android] fix page oin slider can not receive the lifecycle callbacks
atomtong added a commit to atomtong/incubator-weex that referenced this pull request Nov 29, 2017
* master:
  * [doc] publish 0.17.0 release note
  [WEEX-112][iOS] make weex playground app adapt to iPhone X
  close apache#896
  * [test] bug fix , compatibility of maraca can't find element
  [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it.
  close apache#822
  Add mavenLocal before jcenter repository
  Remove maven central repository, use only jcenter
  close apache#790,close apache#796,close apache#801,close apache#803
  close apache#884,close apache#886,close apache#889
  -[test] close apache#887
  resolve apache#887
  [WEEX-132][iOS] support text writing direction from right to left
  [WEEX-133][iOS] support word-wrap on iOS when drawing text
  [WEEX-129][android] Appear Event Be Fired Multi Times And Event not watch be fired
  [WEEX-124][android]fix android bug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants