This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
Remove maven central repository, use only jcenter #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcenter is a super set on top of maven central, so having both of those repositories is redundant, and the preferred one should be jcenter.
Generated by 🚫 dangerJS |
|
Thanks for your contribution. we can remove the |
|
Certainly not. |
|
Sorry I mean replace repositories {
mavenLocal()
jcenter()
}First find in the local maven cache, if not found, find in jcenter |
|
Ah, sure, that's ok, sorry for the misunderstanding. I think it is implicit, but it's ok to have it anyway. |
misakuo
reviewed
Nov 21, 2017
| @@ -1,7 +1,6 @@ | |||
|
|
|||
| buildscript { | |||
| repositories { | |||
| mavenCentral() | |||
misakuo
suggested changes
Nov 21, 2017
Ensure trying to resolve dependencies from local maven cache first, before resolving from remove jcenter repository. This is due to a comment in the pull request.
misakuo
approved these changes
Nov 21, 2017
atomtong
added a commit
to atomtong/incubator-weex
that referenced
this pull request
Nov 29, 2017
* master: * [doc] publish 0.17.0 release note [WEEX-112][iOS] make weex playground app adapt to iPhone X close apache#896 * [test] bug fix , compatibility of maraca can't find element [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it. close apache#822 Add mavenLocal before jcenter repository Remove maven central repository, use only jcenter close apache#790,close apache#796,close apache#801,close apache#803 close apache#884,close apache#886,close apache#889 -[test] close apache#887 resolve apache#887 [WEEX-132][iOS] support text writing direction from right to left [WEEX-133][iOS] support word-wrap on iOS when drawing text [WEEX-129][android] Appear Event Be Fired Multi Times And Event not watch be fired [WEEX-124][android]fix android bug
atomtong
added a commit
to atomtong/incubator-weex
that referenced
this pull request
Nov 29, 2017
…eption * release-0.16-gitlab: * [doc] publish 0.17.0 release note [WEEX-112][iOS] make weex playground app adapt to iPhone X close apache#896 * [test] bug fix , compatibility of maraca can't find element [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it. close apache#822 Add mavenLocal before jcenter repository Remove maven central repository, use only jcenter * [android] avoid crash on some device caused by RippleDrawable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jcenter is a super set on top of maven central, so having both of those repositories is redundant, and the preferred one should be jcenter.
CheckList:
(checked, although not really relevant - not a feature nor bug...)