New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-132][iOS] support text writing direction from right to left #886

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@acton393
Member

acton393 commented Nov 17, 2017

It is a common sense that people have different writing tradition, especially on
writing direction, so text component must consider about the writing direction,
if specify the direction in style is rtl, then the text writing direction will be right
to left and right aligned, ltr or doesn't specify any direction value, the direction
will be left to right default.

Bug: 132

try case : http://dotwe.org/vue/a8874f7b8156029d31e5202c3a7f660b

[WEEX-132][iOS] support text writing direction from right to left
 It is a common sense that people have different writing tradition, especially on
writing direction, so text component must consider about the writing direction,
if specify the direction in style is `rtl`, then the text writing direction will be right
to left and right aligned, 	`ltr` or doesn't specify any direction value, the direction
will be left to right default.

Bug: 132
@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Nov 17, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

weex-bot commented Nov 17, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@asfgit asfgit closed this in b94949b Nov 20, 2017

atomtong added a commit to atomtong/incubator-weex that referenced this pull request Nov 29, 2017

Merge branch 'master' into android-feature-dev-tools-exception
* master:
  close apache#790,close apache#796,close apache#801,close apache#803
  close apache#884,close apache#886,close apache#889
  -[test] close apache#887
  resolve apache#887
  [WEEX-132][iOS] support text writing direction from right to left
  [WEEX-133][iOS] support word-wrap on iOS when drawing text
  [WEEX-129][android] Appear Event Be Fired Multi Times And Event not watch be fired
  [WEEX-124][android]fix android bug
  * [android] fix page oin slider can not receive the lifecycle callbacks

atomtong added a commit to atomtong/incubator-weex that referenced this pull request Nov 29, 2017

Merge branch 'master' into release-0.16-gitlab
* master:
  * [doc] publish 0.17.0 release note
  [WEEX-112][iOS] make weex playground app adapt to iPhone X
  close apache#896
  * [test] bug fix , compatibility of maraca can't find element
  [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it.
  close apache#822
  Add mavenLocal before jcenter repository
  Remove maven central repository, use only jcenter
  close apache#790,close apache#796,close apache#801,close apache#803
  close apache#884,close apache#886,close apache#889
  -[test] close apache#887
  resolve apache#887
  [WEEX-132][iOS] support text writing direction from right to left
  [WEEX-133][iOS] support word-wrap on iOS when drawing text
  [WEEX-129][android] Appear Event Be Fired Multi Times And Event not watch be fired
  [WEEX-124][android]fix android bug

@acton393 acton393 deleted the acton393:ios-feature-text-support-rtl branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment