-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-781] Add queue properties to the response of /ws/v1/partition/{partition}/queues #291
Conversation
I will another PR to update the APIs doc (https://yunikorn.apache.org/docs/api/scheduler) after this PR is accepted |
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 63.46% 65.51% +2.04%
==========================================
Files 60 60
Lines 5220 5709 +489
==========================================
+ Hits 3313 3740 +427
- Misses 1747 1780 +33
- Partials 160 189 +29
Continue to review full report at Codecov.
|
@manirajv06 can u help to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks @manirajv06 is not available right now.
this is a straightforward fix, looks good to me, thank you @chia7712 !
Sorry for the delay. @chia7712 Can we modify TestGetPartitionQueuesHandler in handlers_test.go to cover this change as it would be more appropriate? Can we create a separate PR under this https://issues.apache.org/jira/browse/YUNIKORN-784 jira itself? |
sure
Did you mean "YUNIKORN-781"? YUNIKORN-784 is used to modify website doc. |
|
What is this PR for?
That helps us observe the "application.sort.policy" through REST APIs.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-781
How should this be tested?
TestGetPartitionQueues
Screenshots (if appropriate)
Questions: