Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][TubeMQ] Simplify flush check for appendMsg in FileMsgStore #5303

Closed
2 tasks done
aloyszhang opened this issue Aug 1, 2022 · 0 comments · Fixed by #5304
Closed
2 tasks done

[Improve][TubeMQ] Simplify flush check for appendMsg in FileMsgStore #5303

aloyszhang opened this issue Aug 1, 2022 · 0 comments · Fixed by #5304

Comments

@aloyszhang
Copy link
Contributor

aloyszhang commented Aug 1, 2022

Description

When appending msg, in FileMsgStore, we may need to flush the message(and metadata) to the disk according to the check logic https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/broker/msgstore/disk/MsgFileStore.java?#L199~L206

But these checks are mixed which is hard to comprehend.

We should simplify it in a concise manner.

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@aloyszhang aloyszhang self-assigned this Aug 1, 2022
@dockerzhang dockerzhang added this to the 1.3.0 milestone Aug 1, 2022
@healchow healchow changed the title [Improve] simplify flush check for appendMsg in FileMsgStore [Improve][TubeMQ] Simplify flush check for appendMsg in FileMsgStore Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants