Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][DataProxy] Incorrect readFailSize metric value #5788

Closed
2 tasks done
gosonzhang opened this issue Sep 6, 2022 · 0 comments · Fixed by #5792
Closed
2 tasks done

[Bug][DataProxy] Incorrect readFailSize metric value #5788

gosonzhang opened this issue Sep 6, 2022 · 0 comments · Fixed by #5792
Assignees
@gosonzhang
Labels
component/dataproxy type/bug Something is wrong
Milestone
1.4.0

Comments

@gosonzhang
Copy link
Contributor

gosonzhang commented Sep 6, 2022 •
edited
Loading

What happened

In the case that the sent messages are all successful, the readFailSize value is not 0:
image

From the implementation point of view, it should be caused by an implementation bug:
image

So, we need to adjust it.

What you expected to happen

Should return to zero when all are successful

How to reproduce

Send success messages and check the readFailSize value

Environment

Linux

InLong version

master

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
@gosonzhang gosonzhang added the type/bug Something is wrong label Sep 6, 2022
@gosonzhang gosonzhang self-assigned this Sep 6, 2022
@gosonzhang gosonzhang changed the title [Bug][DataProxy] Wrong readFailSize indicator value [Bug][DataProxy] Incorrect readFailSize metric value Sep 6, 2022
@gosonzhang gosonzhang mentioned this issue Sep 6, 2022
Merged
@dockerzhang dockerzhang added this to the 1.4.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosonzhang gosonzhang

Labels
component/dataproxy type/bug Something is wrong
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

[INLONG-5788][DataProxy] Fix the incorrect readFailSize metric value
2 participants
@gosonzhang @dockerzhang