Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][DataProxy] DataProxy does not fully update the configurations #6040

Closed
2 tasks done
gosonzhang opened this issue Sep 27, 2022 · 0 comments · Fixed by #6041
Closed
2 tasks done

[Bug][DataProxy] DataProxy does not fully update the configurations #6040

gosonzhang opened this issue Sep 27, 2022 · 0 comments · Fixed by #6041
Assignees
Labels
Milestone

Comments

@gosonzhang
Copy link
Contributor

What happened

The method "/inlong/manager/openapi/dataproxy/getConfig" uses the pull mode to obtain full configuration information from the Manager, but saves the configuration information in incremental mode instead of replacement mode[1][2], so that the deleted configuration is still used.

  1. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/ConfigManager.java#L331
    image

  2. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/ConfigManager.java#L138
    image

What you expected to happen

replace, not append

How to reproduce

  1. add topics: a, b, c
  2. remove topic: b
  3. add topic: d

The topic b not be reomved

Environment

Linux

InLong version

master

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants