Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][DataProxy] Delete the cluster.id in the common.properties file #6217

Closed
2 tasks done
gosonzhang opened this issue Oct 19, 2022 · 0 comments · Fixed by #6218
Closed
2 tasks done

[Improve][DataProxy] Delete the cluster.id in the common.properties file #6217

gosonzhang opened this issue Oct 19, 2022 · 0 comments · Fixed by #6218
Assignees
@gosonzhang
Labels
component/dataproxy type/improve
Milestone
1.4.0

Comments

@gosonzhang
Copy link
Contributor

gosonzhang commented Oct 19, 2022 •
edited
Loading

Description

From configuration definitions and code inspection we can see: the cluster.id is not used, and indicates that the cluster and sub-cluster where DataProxy is located have been identified by proxy.cluster.name and proxy.cluster.tag. Even with cluster.id, its functionality is duplicated with these two parameters, which brings complexity to the configuration and will easily confuse users

Considering that cluster.id is not used in the code logic, submit the issue for deletion:

https://github.com/apache/inlong/blob/master/inlong-dataproxy/conf/common.properties#L20
image

InLong Component

InLong DataProxy, InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
@gosonzhang gosonzhang self-assigned this Oct 19, 2022
@gosonzhang gosonzhang changed the title [Improve][DataProxy] Delete the cluster.id parameter in the common.properties file [Improve][DataProxy] Delete the cluster.id in the common.properties file Oct 19, 2022
@gosonzhang gosonzhang mentioned this issue Oct 19, 2022
Merged
@healchow healchow added this to the 1.4.0 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosonzhang gosonzhang

Labels
component/dataproxy type/improve
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

[INLONG-6217][DataProxy] Delete the cluster.id in the common.properties file
2 participants
@gosonzhang @healchow