Add block cancel when GetBlockTask throws exception #5628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A scenario will lead to the invoker wait permanently when using SourceHandle. That is, the SourceHandle's EOS has been received while the GetDataBlockTask is still in progress. And then, the GetDataBlockTask throws exception. If the invoker is waiting the
blocked
future it will be blocked permanently here.Solution
Cancel the
blocked
if the GetDataBlockTask threw exception