Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue that EndTime in FragmentInstanceContext is not set #5636

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Fix the issue that EndTime in FragmentInstanceContext is not set #5636

merged 3 commits into from
Apr 22, 2022

Conversation

xingtanzjr
Copy link
Contributor

Description

  1. When the FragmentInstance is not complete, its endTime is not set. It will lead to NPE when parse it to long when fetching FragmentInstance status.
  2. Fix an issue that the coordinator cannot cleanup QueryExecution if the QueryExecution throws exception when constructing, which will lead to client stuck.

JackieTien97
JackieTien97 requested changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is executionEndTime.compareAndSet(null, now); in updateStatsIfDone of FragmentInstanceContext, you can change it to executionEndTime.compareAndSet(-1, now);

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 54.182% when pulling 6db6e96 on xingtanzjr/fix_coordinator_cleanup into 6952eed on master.

@xingtanzjr
Copy link
Contributor Author

There is executionEndTime.compareAndSet(null, now); in updateStatsIfDone of FragmentInstanceContext, you can change it to executionEndTime.compareAndSet(-1, now);

fixed

@xingtanzjr xingtanzjr closed this Apr 22, 2022
@xingtanzjr xingtanzjr reopened this Apr 22, 2022
@JackieTien97 JackieTien97 merged commit 8df96c5 into master Apr 22, 2022
@JackieTien97 JackieTien97 deleted the xingtanzjr/fix_coordinator_cleanup branch April 22, 2022 06:21
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

49.0% 49.0% Coverage
1.3% 1.3% Duplication

xinzhongtianxia pushed a commit to xinzhongtianxia/iotdb that referenced this pull request Apr 24, 2022
Merge remote-tracking branch 'remotes/upstream/master' into mpp_count
495b963 
* remotes/upstream/master:
  Serialize measurement schema of insert node to wal entry (apache#5638)
  filter non schemaRegionDir (apache#5640)
  [IOTDB-2976] Add English and Chinese docs for count devices and count storage groups (apache#5635)
  change jenkins timeout from 2 hours to 3 hours
  [IOTDB-2740] Equal size bucket sampling UDFs: EQUAL_SIZE_BUCKET_RANDOM_SAMPLE, EQUAL_SIZE_BUCKET_AGG_SAMPLE, EQUAL_SIZE_BUCKET_M4_SAMPLE (apache#5518)
  Fix the issue that EndTime in FragmentInstanceContext is not set (apache#5636)
  fix concurrent bug of CachedMNodeContainer.putIfAbsent (apache#5632)
  [IOTDB-2880] Fix NPE occured in ci test (apache#5634)
  Fix CI (apache#5639)
  Add ColumnMerger to merge multipul input columns of same sensor into one column (apache#5630)
  Add block cancel when GetBlockTask throws exception (apache#5628)
  fix the bug when matching multi-wildcard in pattern tree (apache#5631)
  [IOTDB-2835]Fix empty page in selfcheck method of TsFileSequenceReader (apache#5552)
  Add FragmentInstanceStateMachine for FragmentInstance State change (apache#5615)
  [IOTDB-2880] Fix import check style (apache#5629)
  [IOTDB-2971] Fix sink handle memory leak (apache#5626)
  [rocksdb] updated the interface support (apache#5625)
  [IOTDB-2970] Code style: Avoid wildcard imports (apache#5622)
  [IOTDB-2880]Add procedure framework (apache#5477)
  [rocksdb] add rocksdb properties (apache#5588)

# Conflicts:
#	server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/LocalExecutionPlanner.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackieTien97 JackieTien97 JackieTien97 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xingtanzjr @coveralls @JackieTien97