[IOTDB-2950]Fix concurrent bug of CachedMNodeContainer.putIfAbsent #5632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaojialin
approved these changes
Apr 22, 2022
xinzhongtianxia
pushed a commit
to xinzhongtianxia/iotdb
that referenced
this pull request
Apr 24, 2022
* remotes/upstream/master: Serialize measurement schema of insert node to wal entry (apache#5638) filter non schemaRegionDir (apache#5640) [IOTDB-2976] Add English and Chinese docs for count devices and count storage groups (apache#5635) change jenkins timeout from 2 hours to 3 hours [IOTDB-2740] Equal size bucket sampling UDFs: EQUAL_SIZE_BUCKET_RANDOM_SAMPLE, EQUAL_SIZE_BUCKET_AGG_SAMPLE, EQUAL_SIZE_BUCKET_M4_SAMPLE (apache#5518) Fix the issue that EndTime in FragmentInstanceContext is not set (apache#5636) fix concurrent bug of CachedMNodeContainer.putIfAbsent (apache#5632) [IOTDB-2880] Fix NPE occured in ci test (apache#5634) Fix CI (apache#5639) Add ColumnMerger to merge multipul input columns of same sensor into one column (apache#5630) Add block cancel when GetBlockTask throws exception (apache#5628) fix the bug when matching multi-wildcard in pattern tree (apache#5631) [IOTDB-2835]Fix empty page in selfcheck method of TsFileSequenceReader (apache#5552) Add FragmentInstanceStateMachine for FragmentInstance State change (apache#5615) [IOTDB-2880] Fix import check style (apache#5629) [IOTDB-2971] Fix sink handle memory leak (apache#5626) [rocksdb] updated the interface support (apache#5625) [IOTDB-2970] Code style: Avoid wildcard imports (apache#5622) [IOTDB-2880]Add procedure framework (apache#5477) [rocksdb] add rocksdb properties (apache#5588) # Conflicts: # server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/LocalExecutionPlanner.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the causes
The
CachedMNodeContainer.putIfAbsentis not thread-safe, which may results in subTree loss or unexpected replacement when creating timeseries concurrently.Solution
Rewrite
CachedMNodeContainer.putIfAbsentand make it synchronized.