Skip to content

Commit

Permalink
KAFKA-10592: Fix vagrant for a system tests with python3
Browse files Browse the repository at this point in the history
Fix vagrant for a system tests with a python3.

Author: Nikolay Izhikov <nizhikov@apache.org>

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>

Closes #9480 from nizhikov/KAFKA-10592

(cherry picked from commit c8c1baf)
Signed-off-by: Manikumar Reddy <manikumar.reddy@gmail.com>
  • Loading branch information
nizhikov authored and omkreddy committed Oct 24, 2020
1 parent d2917a6 commit 35eea09
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -404,9 +404,9 @@ https://cwiki.apache.org/confluence/display/KAFKA/tutorial+-+set+up+and+run+Kafk
* Install system test dependencies, including ducktape, a command-line tool and library for testing distributed systems. We recommend to use virtual env for system test development

$ cd kafka/tests
$ virtualenv venv
$ virtualenv -p python3 venv
$ . ./venv/bin/activate
$ python setup.py develop
$ python3 setup.py develop
$ cd .. # back to base kafka directory

* Run the bootstrap script to set up Vagrant for testing
Expand Down Expand Up @@ -482,7 +482,7 @@ the test driver machine.

* Start by making sure you're up to date, and install git and ducktape:

$ sudo apt-get update && sudo apt-get -y upgrade && sudo apt-get install -y python-pip git
$ sudo apt-get update && sudo apt-get -y upgrade && sudo apt-get install -y python3-pip git
$ pip install ducktape

* Get Kafka:
Expand Down Expand Up @@ -548,7 +548,7 @@ Where are the unit tests?

How do I run the unit tests?
* cd kafka/tests # The base system test directory
* python setup.py test
* python3 setup.py test

How can I add a unit test?
* Follow the naming conventions - module name starts with "check", class name begins with "Check", test method name begins with "check"
Expand Down
2 changes: 1 addition & 1 deletion tests/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def run_tests(self):
license="apache2.0",
packages=find_packages(),
include_package_data=True,
install_requires=["ducktape==0.7.9", "requests==2.22.0"],
install_requires=["ducktape==0.8.0", "requests==2.24.0"],
tests_require=["pytest", "mock"],
cmdclass={'test': PyTest},
)

0 comments on commit 35eea09

Please sign in to comment.