Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-12383: Get RaftClusterTest.java and other KIP-500 junit tests working #10220

Merged
merged 19 commits into from
Mar 22, 2021

Conversation

mumrah
Copy link
Contributor

@mumrah mumrah commented Feb 26, 2021

Adds KafkaClusterTestKit, an integration test framework for starting up Kafka brokers and controllers in Raft mode. This was authored by @cmccabe on the kip-500 development branch. See RaftClusterTest for example usage

Also included here is the support for Raft mode in the JUnit integration test extensions. See ClusterTestExtensionsTest for example usage

@mumrah mumrah marked this pull request as ready for review February 27, 2021 01:30
@cmccabe cmccabe changed the title Minor: TestKit for Raft controller integration tests KAFKA-12383: Get RaftClusterTest.java and other KIP-500 junit tests working Feb 27, 2021
Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few small cleanups.

core/src/test/java/kafka/test/annotation/Type.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/test/annotation/Type.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java Outdated Show resolved Hide resolved
@mumrah mumrah merged commit e820eb4 into apache:trunk Mar 22, 2021
Terrdi pushed a commit to Terrdi/kafka that referenced this pull request Apr 1, 2021
…orking (apache#10220)

Introduce "testkit" package which includes KafkaClusterTestKit class for enabling integration tests of self-managed clusters. Also make use of this new integration test harness in the ClusterTestExtentions JUnit extension. 

Adds RaftClusterTest for basic self-managed integration test. 

Reviewers: Jason Gustafson <jason@confluent.io>, Colin P. McCabe <cmccabe@apache.org>

Co-authored-by: Colin P. McCabe <cmccabe@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants