KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore #10294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
changed the title
Merged
3 tasks
|
@jeqo could you rebase the PR while I review it? |
|
@guozhangwang, it should be ready for review now. thanks! |
guozhangwang
reviewed
May 3, 2021
There was a problem hiding this comment.
Just one nit, otherwise LGTM.
Also could you rebase the PR? Thanks @jeqo !
| public WindowStoreIterator<V> fetch(final K key, | ||
| final long timeFrom, | ||
| final long timeTo) { | ||
| final Instant timeFrom, |
There was a problem hiding this comment.
Seems we are removing the ApiUtils.validateMillisecondInstant check here, is that intentional?
There was a problem hiding this comment.
Yes, default implementation is doing this convertion already.
|
Merged to trunk, thanks @jeqo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement first part of https://cwiki.apache.org/confluence/display/KAFKA/KIP-667%3A+Remove+deprecated+methods+from+ReadOnlyWindowStore. Preparing it for v3.0
Committer Checklist (excluded from commit message)