KAFKA-12607: Test case for resigned state vote granting #10510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachikuji
reviewed
Apr 9, 2021
hachikuji
approved these changes
Apr 9, 2021
jthurne
added a commit
to jthurne/kafka
that referenced
this pull request
Apr 12, 2021
* origin/trunk: (27 commits) MINOR: Remove some unnecessary cyclomatic complexity suppressions (apache#10488) MINOR: Remove gradleSetup from Jenkinsfile (apache#10522) MINOR: Use `testRuntimeOnly` instead of `testRuntime` in storage modules (apache#10524) KAFKA-12607; Test case for resigned state vote granting (apache#10510) HOTFIX: delete removed WindowedStore.put() method (apache#10517) KAFKA-8410: Migrate KStream Stateless operators to new Processor API (apache#10381) KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance (apache#10301) MINOR: Fix typo in docs (apache#10423) KAFKA-12449: Remove deprecated WindowStore#put (apache#10293) MINOR: Fix left/outer join descriptions in Streams DSL reference topic (apache#10453) MINOR: add missing TimeoutException to Producer.send JavaDocs (apache#10495) KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations (apache#10427) KAFKA-12492: Fix the formatting of example RocksDBConfigSetter (apache#10486) KAFKA-12406 Integrate client quotas with KRaft broker (apache#10254) KAFKA-12619; Raft leader should expose hw only after committing LeaderChange (apache#10481) KAFKA-12457; Add sentinel ID to metadata topic (apache#10492) HOTFIX: add missing upgrade docs KAFKA-12630: Remove deprecated KafkaClientSupplier#getAdminClient in Streams (apache#10502) MINOR: Remove redundant code from ReplicaManagerTest#testFetchMessagesWhenNotFollowerForOnePartition (apache#10501) MINOR: Update Crc32Test#testUpdate method with correct Crc32 (apache#10406) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
As discussed in the Jira,
ResignedStatewill transition toVotedStateand grant vote, just add some unit tests to verify this transition.Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)