KAFKA-2399; Replace Stream.continually with Iterator.continually
#106
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kafka-trunk-git-pr #79 SUCCESS |
|
+1. @gwenshap or @guozhangwang this is a pretty trivial patch, should be easy to get committed. |
ijuma
force-pushed
the
kafka-2399-replace-stream-continually
branch
from
68531ed
to
bc57bb9
Compare
ijuma
force-pushed
the
kafka-2399-replace-stream-continually
branch
from
bc57bb9
to
fa97ebf
Compare
ijuma
force-pushed
the
kafka-2399-replace-stream-continually
branch
from
fa97ebf
to
8c115a3
Compare
ambroff
pushed a commit
to ambroff/kafka
that referenced
this pull request
Jan 20, 2021
…pon PR and push (apache#106) Add a Github Actions workflow to trigger build and test upon the below conditions. - Create/open a new pull request - Re-open a pull request - Synchronized a pull request TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = N/A
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jan 7, 2022
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (apache#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (apache#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (apache#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (apache#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (apache#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (apache#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (apache#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterator.continuallyis more efficient (it doesn't allocate aConsinstance per element) and we don't need the extra functionality provided byStream.continually.