KAFKA-10859: Add test annotation to FileStreamSourceTaskTest.testInvalidFile and speed up the test #11169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Sep 4, 2021
| public void testInvalidFile() throws InterruptedException { | ||
| replay(); |
There was a problem hiding this comment.
pardon me. why it needs to call replay()?
| // Currently the task retries indefinitely if the file isn't found, but shouldn't return any data. | ||
| for (int i = 0; i < 100; i++) | ||
| assertNull(task.poll()); | ||
| assertNull(task.poll()); |
There was a problem hiding this comment.
How about calling the poll again to make sure it does not cause error?
|
This is fixed by 3dacdc5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*More detailed description of your change,
Added the missing @test annotation to a test in FileStreamSourceTaskTest. The test used to loop 100 times, each time blocking for 1 second. Checking the assertion more than once is unnecessary for this test.
Committer Checklist (excluded from commit message)