KAFKA-13231; TransactionalMessageCopier.start_node should wait until the process if fully started
#11264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l the process if fully started
|
Transactions system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4663/ |
hachikuji
reviewed
Aug 26, 2021
| @@ -159,12 +159,16 @@ def pids(self, node): | |||
| def alive(self, node): | |||
| return len(self.pids(node)) > 0 | |||
|
|
|||
| def start_node(self, node): | |||
| BackgroundThreadService.start_node(self, node) | |||
| wait_until(lambda: self.alive(node), timeout_sec=60, err_msg="Message Copier failed to start") | |||
There was a problem hiding this comment.
Is it worth adding node to these error messages?
|
@hachikuji updated the PR to add the node to the error message. |
|
New run to validate: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4665/ |
hachikuji
approved these changes
Aug 26, 2021
dajac
added a commit
that referenced
this pull request
Aug 27, 2021
…l the process if fully started (#11264) This patch ensures that the transaction message copier is fully started in `start_node`. Without this, it is possible that `stop_node` is called before the process is started which results in not stopping it at all. Reviewers: Jason Gustafson <jason@confluent.io>
dajac
added a commit
that referenced
this pull request
Aug 27, 2021
…l the process if fully started (#11264) This patch ensures that the transaction message copier is fully started in `start_node`. Without this, it is possible that `stop_node` is called before the process is started which results in not stopping it at all. Reviewers: Jason Gustafson <jason@confluent.io>
|
Merged to trunk, 3.0 and 2.8. |
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
…l the process if fully started (apache#11264) This patch ensures that the transaction message copier is fully started in `start_node`. Without this, it is possible that `stop_node` is called before the process is started which results in not stopping it at all. Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)