KAFKA-13433:JsonConverter's method convertToJson when field is optional with default value and value is null, return default value. #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ewencp Please cc. |
GOODBOY008
force-pushed
the
KAFKA-13433
branch
2 times, most recently
from
9d1b153
to
fd4ef39
Compare
GOODBOY008
force-pushed
the
KAFKA-13433
branch
from
cc26372
to
deb2191
Compare
GOODBOY008
force-pushed
the
KAFKA-13433
branch
from
deb2191
to
215d4f9
Compare
…al with default value and value is null, return default value.
|
@kkonstantine Please review , If you are available ,Thank you! |
|
Is anyone watching this? We have same issue. It's sad that it hasn't been reviewed for a year, even though the bugs are obvious. @GOODBOY008 How are you handling this issue? |
|
Fixed in #13781 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is here .
Problem:
JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.
It should return
nullvalue.I found this scene when use debezium as cdc source. I create a table with a field (optional with default value), insert into a row with 'null' value, but got default value from debezium, with debug source code I found kafka-connect class 'JsonConverter'.