KAFKA-8713: JsonConverter replace.null.with.default should apply to Struct fields #13781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itting default for Struct fields Signed-off-by: Greg Harris <greg.harris@aiven.io> Co-authored-by: GeunJae Jeon (krespo) (louis.ii) <>
mimaison
pushed a commit
that referenced
this pull request
May 31, 2023
…itting default for Struct fields (#13781) Co-authored-by: GeunJae Jeon <krespo> Reviewers: Mickael Maison <mickael.maison@gmail.com>
3 tasks
emissionnebula
added a commit
to confluentinc/kafka
that referenced
this pull request
Jun 16, 2023
…tream-3.5 * commit 'c2f6f29ca6e1306ac77ec726bac4cd09bd1aa80b': (76 commits) KAFKA-15019: Improve handling of broker heartbeat timeouts (apache#13759) KAFKA-15003: Fix ZK sync logic for partition assignments (apache#13735) MINOR: Add 3.5 upgrade steps for ZK and KRaft (apache#13792) KAFKA-15010 ZK migration failover support (apache#13758) KAFKA-15017 Fix snapshot load in dual write mode for ClientQuotas and SCRAM (apache#13757) MINOR: Update LICENSE-binary following snappy upgrade (apache#13791) Upgrade to snappy v1.1.10.0 (apache#13786) KAFKA-15004: Fix configuration dual-write during migration (apache#13767) KAFKA-8713: JsonConverter replace.null.with.default should prevent emitting default for Struct fields (apache#13781) KAFKA-14996: Handle overly large user operations on the kcontroller (apache#13742) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "replace.null.with.default" option is a KIP-581 addition that is intended to (when false) prevent the Connect default values from being emitted in the JsonConverter. The current implementation works for root values, but does not work for Structs, as the Struct::get implementation has logic to substitute the default value if no value is present.
Instead, the JsonConverter should call Struct::getWithoutDefault, and hide the default value for Struct fields when "replace.null.with.default" is false.
This should be backported to 3.5
Supersedes #13748
Committer Checklist (excluded from commit message)