KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails. #11830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cpu and traffic on the broker side increase sharply JIRA link : https://issues.apache.org/jira/browse/KAFKA-13310 Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
…sets method JIRA link : https://issues.apache.org/jira/browse/KAFKA-13310 Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
2. Optimize the import of package Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
add test Method "testForceMetadataDeleteForPatternSubscriptionDuringRebalance()" Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us> Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 riven.sun@zoom.us
� Conflicts: � clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
…ints more specific information when the verification record fails. Story JIRA: https://issues.apache.org/jira/browse/KAFKA-13694
|
Hi @guozhangwang @showuon |
|
Thanks @RivenSun2 , the changes LGTM. |
|
Looked into the jenkins and they are irrelevant. Merging to trunk. |
|
Hi @guozhangwang |
|
JIRA status updated. Thanks for the contribution! |
ijuma
reviewed
Mar 5, 2022
| @@ -571,13 +571,9 @@ private[log] object LogValidator extends Logging { | |||
| private def processRecordErrors(recordErrors: Seq[ApiRecordError]): Unit = { | |||
| if (recordErrors.nonEmpty) { | |||
| val errors = recordErrors.map(_.recordError) | |||
| if (recordErrors.exists(_.apiError == Errors.INVALID_TIMESTAMP)) { | |||
There was a problem hiding this comment.
We do we no longer need this special case?
There was a problem hiding this comment.
Yes, looks like we need this, because we break 2 test cases after removing it. PR to bring it back to fix failed tests is opened: #11853 . Thanks.
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Story JIRA: https://issues.apache.org/jira/browse/KAFKA-13694