-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-13852: Kafka Acl documentation bug for wildcard '*' #12090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hongten , thanks for the PR. So you mean the *
without single quote will be replaced into all files under the current folder by bash
, right? Interesting issue. Could you also update the option description in core/src/main/scala/kafka/admin/AclCommand.scala
? i.e.:
A value of * indicates ACL should apply to all topics.
-> A value of '*' indicates ACL should apply to all topics.
(add single quote around *)
Thanks.
hi @showuon , the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
Failed tests are unrelated:
|
@Hongten , thanks for the contribution! |
The bug for wildcard '*' in Kafka Acl documentation(docs/security.html).
In this fix, add single quotes for the wildcard '*' in the script.
Committer Checklist (excluded from commit message)