KAFKA-14446: code style improvements for broker-to-controller forwarding #13001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forwarding patch Original patch: https://github.com/apache/kafka/pull/12961/files#
cmccabe
changed the title
cmccabe
reviewed
Dec 16, 2022
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
Outdated
Show resolved
Hide resolved
cmccabe
reviewed
Dec 16, 2022
| @@ -703,8 +703,8 @@ class KafkaServer( | |||
| case None => | |||
| info(s"Broker registration for controller $controllerId is not available in the metadata cache") | |||
| } | |||
| case None => | |||
| info("No controller present in the metadata cache") | |||
| case _ => | |||
There was a problem hiding this comment.
this one confuses me. Isn't case None clearer than case _ ?
There was a problem hiding this comment.
The condition covers more than None. It includes Some(controller: KRaftCachedControllerId) as well.
There was a problem hiding this comment.
Let me add more explicit condition to prevent this confusion.
cmccabe
approved these changes
Dec 16, 2022
ijuma
reviewed
Dec 17, 2022
This reverts commit b488c09.
cmccabe
pushed a commit
that referenced
this pull request
Jan 5, 2023
…ing (#13001) Reviewers: Colin P. McCabe <cmccabe@apache.org>, Ismael Juma <ismael@juma.me.uk>, David Arthur <mumrah@gmail.com>
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…ing (apache#13001) Reviewers: Colin P. McCabe <cmccabe@apache.org>, Ismael Juma <ismael@juma.me.uk>, David Arthur <mumrah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…forwarding patch
Original patch: https://github.com/apache/kafka/pull/12961/files#