KAFKA-14491: [20/N] Add public-facing methods for versioned stores #13442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
mjsax
approved these changes
Mar 28, 2023
| * The only impact of this parameter is performance. If segments are large | ||
| * and a workload results in many record versions for the same key being collected | ||
| * in a single segment, performance may degrade as a result. On the other hand, | ||
| * reads and out-of-order writes which access older segments may slow down if |
There was a problem hiding this comment.
[history] reads (regular "most recent" reads are not affected, right)?
There was a problem hiding this comment.
Yeah, that's correct. Updated.
3 tasks
vcrfxia
force-pushed
the
kip-889-stores-java
branch
from
40ff80d
to
485eade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until this PR, all the code added for KIP-889 for introducing versioned stores to Kafka Streams has been accessible from internal packages only. This PR exposes the stores via public Stores.java methods, and also updates the TopologyTestDriver.
Committer Checklist (excluded from commit message)