-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-3761: Remove BrokerState "RunningAsController" #1437
Conversation
EasyMock.expect(mockBrokerState.newState(RunningAsBroker)).andDelegateTo(brokerStateInterceptor).once() | ||
EasyMock.expect(mockBrokerState.newState(RunningAsController)).andDelegateTo(brokerStateInterceptor).once() | ||
EasyMock.expect(mockBrokerState.newState(BrokerShuttingDown)).once() | ||
EasyMock.expect(mockBrokerState.newState(NotRunning)).once() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be a good idea to have a second broker that is not a controller and verify the behaviour for that too.
36dcafe
to
c0201c5
Compare
I spoke with @junrao and he agreed that removing it seemed best. |
Can you please update the PR title and description? Note that the PR description becomes the comment in the merged commit, so it should focus on the change only. The change LGTM, but let's wait for the outcome of the mailing list discussion you started @theduderog. |
retest this please |
We also need a note in upgrade.html. |
@ijuma I've add a note in the upgrade doc if you can take a look. |
@@ -118,6 +118,12 @@ | |||
<li> The new consumer API has been marked stable. </li> | |||
</ul> | |||
|
|||
<h5><a id="upgrade_101_notable" href="#upgrade_101_notable">Notable changes in 0.10.0.1</a></h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will be in 0.10.1.0, not 0.10.0.1 (the latter only includes bug fixes).
Updated upgrade doc based on @ijuma's feedback. |
LGTM |
Still failing on KStreams test: |
LGTM |
This time it's failing on ssl producer test:
|
No objections in the mailing list and 3 +1s (two from committers). Jun also agrees according to Roger's comment. Tests passed locally, merged to trunk. |
The reasons to remove it are:
a. If clients want to use this metric to know whether a broker is ready to receive requests or not, they do not care whether or not the broker is the controller
b. there is already a separate boolean property, KafkaController.isActive which contains this information.