KAFKA-16139: Fix StreamsUpgradeTest #15199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds version 3.5 to the possible values for config upgrade_from.
|
@mjsax Could you have a look since you reviewed also the PR that added upgrade tests to version 3.5? |
|
I started Streams system tests here: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6034/ |
|
Is this fix sufficient? Don't we not also need to add |
mjsax
approved these changes
Jan 17, 2024
|
I just checked the test failures on #15151 (cf last comment) and it failed because |
mjsax
pushed a commit
that referenced
this pull request
Jan 17, 2024
Adds version 3.5 to the possible values for config upgrade_from. Reviewers: Matthias J. Sax <matthias@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Jan 17, 2024
Adds version 3.5 to the possible values for config upgrade_from. Reviewers: Matthias J. Sax <matthias@confluent.io>
|
Merged to |
|
Follow-up PR to add |
mjsax
added a commit
to mjsax/kafka
that referenced
this pull request
Jan 17, 2024
Follow up to apache#15199 Remove unnecessary import and add new member variable.
Merged
mjsax
reviewed
Jan 17, 2024
| @@ -71,6 +71,7 @@ | |||
| import static org.apache.kafka.common.config.ConfigDef.Range.between; | |||
| import static org.apache.kafka.common.config.ConfigDef.ValidString.in; | |||
| import static org.apache.kafka.common.config.ConfigDef.parseType; | |||
| import static org.apache.kafka.streams.internals.UpgradeFromValues.UPGRADE_FROM_35; | |||
There was a problem hiding this comment.
After merging and doing the follow up PR to add 3.6, I realized that using this import is not what we want to do.
Call for review (follow up cleanup PR): #15208
mjsax
added a commit
to mjsax/kafka
that referenced
this pull request
Jan 17, 2024
Follow up to apache#15199 Remove unnecessary import and add new member variable.
mjsax
added a commit
that referenced
this pull request
Jan 18, 2024
Follow up to #15199 Remove unnecessary import and add new member variable. Reviewers: Walker Carlson <wcarlson@confluent.io>
dajac
pushed a commit
to dajac/kafka
that referenced
this pull request
Jan 19, 2024
Adds version 3.5 to the possible values for config upgrade_from. Reviewers: Matthias J. Sax <matthias@confluent.io>
showuon
pushed a commit
to showuon/kafka
that referenced
this pull request
Jan 22, 2024
Adds version 3.5 to the possible values for config upgrade_from. Reviewers: Matthias J. Sax <matthias@confluent.io>
gaurav-narula
pushed a commit
to gaurav-narula/kafka
that referenced
this pull request
Jan 24, 2024
Adds version 3.5 to the possible values for config upgrade_from. Reviewers: Matthias J. Sax <matthias@confluent.io>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
Adds version 3.5 to the possible values for config upgrade_from. Reviewers: Matthias J. Sax <matthias@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
Adds version 3.5 to the possible values for config upgrade_from. Reviewers: Matthias J. Sax <matthias@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds version 3.5 to the possible values for config upgrade_from.
Committer Checklist (excluded from commit message)