Skip to content

Commit

Permalink
KAFKA-16139: Fix StreamsUpgradeTest (apache#15199)
Browse files Browse the repository at this point in the history
Adds version 3.5 to the possible values for config upgrade_from.

Reviewers: Matthias J. Sax <matthias@confluent.io>
  • Loading branch information
cadonna authored and showuon committed Jan 22, 2024
1 parent ee356b6 commit fe04b4e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
Expand Up @@ -71,6 +71,7 @@
import static org.apache.kafka.common.config.ConfigDef.Range.between;
import static org.apache.kafka.common.config.ConfigDef.ValidString.in;
import static org.apache.kafka.common.config.ConfigDef.parseType;
import static org.apache.kafka.streams.internals.UpgradeFromValues.UPGRADE_FROM_35;

/**
* Configuration for a {@link KafkaStreams} instance.
Expand Down Expand Up @@ -762,7 +763,8 @@ public class StreamsConfig extends AbstractConfig {
UPGRADE_FROM_22 + "\", \"" + UPGRADE_FROM_23 + "\", \"" + UPGRADE_FROM_24 + "\", \"" +
UPGRADE_FROM_25 + "\", \"" + UPGRADE_FROM_26 + "\", \"" + UPGRADE_FROM_27 + "\", \"" +
UPGRADE_FROM_28 + "\", \"" + UPGRADE_FROM_30 + "\", \"" + UPGRADE_FROM_31 + "\", \"" +
UPGRADE_FROM_32 + "\", \"" + UPGRADE_FROM_33 + "\", \"" + UPGRADE_FROM_34 + "\" (for upgrading from the corresponding old version).";
UPGRADE_FROM_32 + "\", \"" + UPGRADE_FROM_33 + "\", \"" + UPGRADE_FROM_34 + "\", \"" +
UPGRADE_FROM_35 + "(for upgrading from the corresponding old version).";

/** {@code windowstore.changelog.additional.retention.ms} */
@SuppressWarnings("WeakerAccess")
Expand Down
Expand Up @@ -36,7 +36,8 @@ public enum UpgradeFromValues {
UPGRADE_FROM_31("3.1"),
UPGRADE_FROM_32("3.2"),
UPGRADE_FROM_33("3.3"),
UPGRADE_FROM_34("3.4");
UPGRADE_FROM_34("3.4"),
UPGRADE_FROM_35("3.5");

private final String value;

Expand Down
Expand Up @@ -125,6 +125,7 @@ public RebalanceProtocol rebalanceProtocol() {
case UPGRADE_FROM_32:
case UPGRADE_FROM_33:
case UPGRADE_FROM_34:
case UPGRADE_FROM_35:
// we need to add new version when new "upgrade.from" values become available

// This config is for explicitly sending FK response to a requested partition
Expand Down Expand Up @@ -183,6 +184,7 @@ public int configuredMetadataVersion(final int priorVersion) {
case UPGRADE_FROM_32:
case UPGRADE_FROM_33:
case UPGRADE_FROM_34:
case UPGRADE_FROM_35:
// we need to add new version when new "upgrade.from" values become available

// This config is for explicitly sending FK response to a requested partition
Expand Down

0 comments on commit fe04b4e

Please sign in to comment.